Fix: Handle invalid form hashes correctly#2655
Merged
Chartman123 merged 1 commit intomainfrom Mar 30, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2655 +/- ##
============================================
- Coverage 43.34% 43.31% -0.04%
- Complexity 887 888 +1
============================================
Files 78 78
Lines 3368 3371 +3
============================================
Hits 1460 1460
- Misses 1908 1911 +3 🚀 New features to boost your workflow:
|
Chartman123
force-pushed
the
fix/2651
branch
3 times, most recently
from
bbeeecb to
7386c48
Compare
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
Chartman123
added
3. to review
Collaborator
Author
|
/backport to stable4 |
AndyScherzinger
approved these changes
Mar 30, 2025
backportbot
Bot
removed
the
backport-request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #2651 by correctly catching the NotFoundException in the backend and passing a corresponding value to the inital state of the app.
The
formIdis then checked against the defined value and routeAllowed returnsfalsewhich then shows the correct error message that the form could not be found.